Skip to content

chore: Add configuration files for Gemini PR reviews#7577

Merged
matthewelwell merged 2 commits into
mainfrom
chore/add-gemini-configuration
Jun 1, 2026
Merged

chore: Add configuration files for Gemini PR reviews#7577
matthewelwell merged 2 commits into
mainfrom
chore/add-gemini-configuration

Conversation

@matthewelwell
Copy link
Copy Markdown
Contributor

@matthewelwell matthewelwell commented May 22, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Adds configuration file for gemini code reviews as per schema here. Note that I have populated all fields, using default values where sufficient for our usage as I preferred to be explicit rather than implicit. Happy to remove default values if requested.

I also added the style guide, currently just pulled directly from the Notion page on our approach to PRs here.

How did you test this code?

N/a - will need testing with gemini code review after merge.

@matthewelwell matthewelwell requested a review from a team as a code owner May 22, 2026 10:40
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team May 22, 2026 10:40
claude[bot]
claude Bot reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 29, 2026 4:14pm
flagsmith-frontend-preview Ignored Ignored Preview May 29, 2026 4:14pm
flagsmith-frontend-staging Ignored Ignored Preview May 29, 2026 4:14pm

Request Review

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented May 22, 2026

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the chore label May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7577 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7577 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-7577 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7577 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-7577 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7577 Finished ✅ Results ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39 seconds
commit  927ccfc
info  🔄 Run: #16911 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  43 seconds
commit  927ccfc
info  🔄 Run: #16911 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  34.7 seconds
commit  927ccfc
info  🔄 Run: #16911 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  43 seconds
commit  927ccfc
info  🔄 Run: #16911 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  43.5 seconds
commit  0827755
info  🔄 Run: #17116 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39 seconds
commit  0827755
info  🔄 Run: #17116 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  45.8 seconds
commit  0827755
info  🔄 Run: #17116 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 3 seconds
commit  0827755
info  🔄 Run: #17116 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026 •
edited
Loading

Visual Regression

19 screenshots compared. See report for details.
View full report

matthewelwell
matthewelwell commented May 22, 2026
View reviewed changes
Comment thread .gemini/config.yaml
Comment thread .gemini/config.yaml
@matthewelwell matthewelwell changed the title chore: Add .gemini/config.yaml and styleguide.md chore: Add configuration files for Gemini PR reviews May 22, 2026
Zaimwa9
Zaimwa9 reviewed May 22, 2026
View reviewed changes
Comment thread .gemini/styleguide.md Outdated
@github-actions github-actions Bot added chore and removed chore labels May 29, 2026
@matthewelwell matthewelwell requested a review from Zaimwa9 May 29, 2026 16:17
@emyller emyller mentioned this pull request May 29, 2026
Merged
2 tasks
khvn26
khvn26 approved these changes Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this

@matthewelwell matthewelwell merged commit 4c81684 into main Jun 1, 2026
25 checks passed
@matthewelwell matthewelwell deleted the chore/add-gemini-configuration branch June 1, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emyller emyller emyller left review comments

@claude claude[bot] claude[bot] left review comments

@khvn26 khvn26 khvn26 approved these changes

@gagantrivedi gagantrivedi Awaiting requested review from gagantrivedi gagantrivedi is a code owner automatically assigned from Flagsmith/flagsmith-engineering

@Zaimwa9 Zaimwa9 Awaiting requested review from Zaimwa9

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthewelwell @emyller @khvn26 @Zaimwa9